Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

castxml: set correct -DCLANG_RESOURCE_DIR #66488

Merged
merged 1 commit into from Aug 15, 2019
Merged

castxml: set correct -DCLANG_RESOURCE_DIR #66488

merged 1 commit into from Aug 15, 2019

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Aug 11, 2019 •
edited

This change fixes #66456

According to the comment in CastXML CMakeLists.txt this variable should point to the directory that contains include/stddef.h. This change fixes the variable, so now built package contains the file.

$ nix-build -A castxml
/nix/store/ry5fhfvi7ixn47a7i9pripn1fq1kbxwr-CastXML-0.2.0
$ ls result/share/castxml/clang/include/stddef.h
result/share/castxml/clang/include/stddef.h

@link2xt
Copy link
Contributor Author

link2xt commented Aug 11, 2019

I have tested it by doing

$ nix-shell -I nixpkgs=$NIXPKGS -p castxml python37Packages.pygccxml

and running all the testcases from issue #66465
NIXPKGS points to my local clone of nixpkgs git tree.

@link2xt link2xt marked this pull request as ready for review August 11, 2019 20:37
@link2xt
Copy link
Contributor Author

link2xt commented Aug 11, 2019

@teto Can you review it and test that it fixes your NS-3 package?

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg eval

@teto
Copy link
Member

teto commented Aug 13, 2019

@link2xt seems like it fixed it !

@teto teto merged commit 6a5213c into NixOS:master Aug 15, 2019
@teto
Copy link
Member

teto commented Aug 15, 2019

thanks for looking into this

@link2xt link2xt deleted the castxml-resource-dir branch August 15, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gloaming gloaming gloaming left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

castxml cannot find stddef.h under nix-shell
5 participants
@link2xt @worldofpeace @teto @gloaming @Janik-Haag