Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdma-core: 24.0 -> 25.0 #66380

Merged
merged 2 commits into from Aug 10, 2019
Merged

rdma-core: 24.0 -> 25.0 #66380

merged 2 commits into from Aug 10, 2019

Conversation

markuskowa
Copy link
Member

Motivation for this change

Regular update. All commands provided by infiniband-diags are already
included in rdma-core, which is required to build infiniband-diags.

Things done
  • updated rdma-core
  • removed infiniband-diags and aliased to rdma-core
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @aij: is there anything that infiniband-diags provides that is not included in rdma-core now?

All commands provided by infiniband-diags are already
included in rdma-core, which is required to build infiniband-diags.
Copy link
Contributor

@aij aij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that all the old infiniband-diags binaries/scripts are now in rdma-core, per diff <(ls /nix/store/rihfdy6kab3z1gck77pz166xl0zbzkla-infiniband-diags-2.2.0/bin/) <(ls /nix/store/l9n02jcsg8xfcy8l3998684kmjaw6nhh-rdma-core-25.0/bin/)

@markuskowa markuskowa merged commit 732c167 into NixOS:master Aug 10, 2019
@markuskowa markuskowa deleted the upd-rdma branch August 10, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants