Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emacs packages update: 2019-08-09 #66360

Merged
merged 1 commit into from Aug 10, 2019
Merged

Emacs packages update: 2019-08-09 #66360

merged 1 commit into from Aug 10, 2019

Conversation

rasendubi
Copy link
Member

Motivation for this change

Update elpa-packages, melpa-packages, melpa-stable-packages.

Checked with nix-instantiate. Also, works fine with my Emacs setup.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Previous update: #62784

cc @rycee (you seem to be interested in Emacs packages updates 🙂 )

@adisbladis adisbladis self-requested a review August 9, 2019 17:18
@adisbladis adisbladis self-assigned this Aug 9, 2019
@adisbladis
Copy link
Member

@rasendubi Thanks for your PR!

We have recently changed the machinery for generating melpa-packages (see #59189).
Please use the new update-melpa script to update Melpa.

jonringer
jonringer reviewed Aug 9, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+169,534 −88
..... oh boy

@rasendubi
Copy link
Member Author

Oh, I missed that. I have removed melpa packages from the PR, so it only updates elpa now.

@adisbladis adisbladis merged commit 496ae0a into NixOS:master Aug 10, 2019
@adisbladis
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees

@adisbladis adisbladis

Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rasendubi @adisbladis @jonringer