Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openxr-loader: init at 1.0.1 #66358

Merged
merged 1 commit into from Aug 18, 2019
Merged

openxr-loader: init at 1.0.1 #66358

merged 1 commit into from Aug 18, 2019

Conversation

Ralith
Copy link
Contributor

@Ralith Ralith commented Aug 9, 2019 •
edited

Motivation for this change

Infrastructure to allow OpenXR applications to find a runtime like Monado or a future version of SteamVR, and headers to allow C/C++ OpenXR applications to be built.

I'm not sure if a custom output for the layers is idiomatic. These are mainly useful when testing OpenXR applications during development, and are not of interest to typical users or builds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member

mmahut commented Aug 9, 2019

@GrahamcOfBorg build openxr-loader

@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

@GrahamcOfBorg build openxr-loader

mmahut
mmahut approved these changes Aug 18, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures

@mmahut mmahut merged commit 6f27f6c into NixOS:master Aug 18, 2019
@Ralith Ralith deleted the openxr-loader branch August 18, 2019 15:32
@Ralith
Copy link
Contributor Author

Ralith commented Aug 18, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ralith @mmahut