Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sympow: 1.018.1 -> 2.023.4 #66388

Merged
merged 2 commits into from Aug 9, 2019
Merged

sympow: 1.018.1 -> 2.023.4 #66388

merged 2 commits into from Aug 9, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Aug 9, 2019 •
edited

Motivation for this change

Maintenance taken over by debian package maintainer jgmbenoit:
https://trac.sagemath.org/ticket/3360#comment:17

This moves sympow to his fork, since there is no offical
version-controlled source repository from the original author and they
do not seem to maintain sympow anymore. We had already accumulated quite
some patches from debian, who have effectively maintained sympow for a
while now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc me

@timokau timokau changed the title Sympow2 sympow: 1.018.1 -> 2.023.4 Aug 9, 2019
@timokau timokau force-pushed the sympow2 branch 2 times, most recently from 36afa23 to bf6146c Compare August 9, 2019 15:26
@timokau
Copy link
Member Author

timokau commented Aug 9, 2019

Currently testing sage locally. Submitted this early to give ofBorg a head start.

@timokau
sympow: 1.018.1 -> 2.023.4
5e58c5f 
Maintenance taken over by debian package maintainer jgmbenoit:
https://trac.sagemath.org/ticket/3360#comment:17

This moves sympow to his fork, since there is no offical
version-controlled source repository from the original author and they
do not seem to maintain sympow anymore. We had already accumulated quite
some patches from debian, who have effectively maintained sympow for a
while now.
@timokau
sage: move sympow cache to .sage
9ef44b3
@timokau
Copy link
Member Author

timokau commented Aug 9, 2019

The new test fails on darwin. This has likely never worked on darwin and I have no means of debugging it, so I'm restricting this to linux.

@timokau timokau merged commit f5674b2 into NixOS:master Aug 9, 2019
@timokau timokau deleted the sympow2 branch August 9, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@timokau