Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scribusUnstable: 2019-01-16 -> 1.5.5 #66389

Merged
merged 1 commit into from Aug 12, 2019

Conversation

erictapen
Copy link
Member

changelog

Also changed the pname from scribus-unstable to just scribus, as this seems to be the more widely used pattern.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also changed the pname from scribus-unstable to just scribus, as this seems to be the more widely used pattern.

That is correct, though note since it was off svn having it as unstable with date is directive from the manual.


Suggestions are how this application should be packaged according to the qt documentation.

pkgs/applications/office/scribus/unstable.nix Outdated Show resolved Hide resolved
pkgs/applications/office/scribus/unstable.nix Outdated Show resolved Hide resolved
pkgs/applications/office/scribus/unstable.nix Outdated Show resolved Hide resolved
@erictapen
Copy link
Member Author

Suggestions are how this application should be packaged according to the qt documentation.

Could you give a link to that documentation? I couldn't find anything about your changes in the Nixpkgs docs (or didn't understand it enough).

That wrapQtAppsHook was introduced by 51d7803 btw and I don't really understand what it does anyway, so no hard feelings about your suggestions.

changelog: https://bugs.scribus.net/changelog_page.php?version_id=106

Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
@erictapen
Copy link
Member Author

Rebased to master and added your suggestions. Thanks for the feedback!

@GrahamcOfBorg build scribusUnstable

@worldofpeace
Copy link
Contributor

Suggestions are how this application should be packaged according to the qt documentation.

Could you give a link to that documentation? I couldn't find anything about your changes in the Nixpkgs docs (or didn't understand it enough).

That wrapQtAppsHook was introduced by 51d7803 btw and I don't really understand what it does anyway, so no hard feelings about your suggestions.

See https://hydra.nixos.org/build/96804884/download/1/nixpkgs/manual.html#sec-language-qt

The part about using mkDerivation and not using anything from qt5.* set.

@worldofpeace
Copy link
Contributor

That's weird. I got the link to the change log from this recent release announcement on their mailing list. I guess the date 2018-04-28 means, that the changelog was released on the last release 1.5.4 and got appended until recently.
I also checked the checksum in the announcement mail and they match with the tar ball introduced by this PR.

Great, I believe you've done all the appropriate checks then.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build scribusUnstable

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and executes for me on x86_64-linux NixOS 👍

@worldofpeace
Copy link
Contributor

Going to skip the x86_64-linux check since I've tested this.

@worldofpeace worldofpeace merged commit bc0f60f into NixOS:master Aug 12, 2019
@erictapen
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants