New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scribusUnstable: 2019-01-16 -> 1.5.5 #66389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also changed the pname from scribus-unstable to just scribus, as this seems to be the more widely used pattern.
That is correct, though note since it was off svn having it as unstable
with date is directive from the manual.
Suggestions are how this application should be packaged according to the qt documentation.
Could you give a link to that documentation? I couldn't find anything about your changes in the Nixpkgs docs (or didn't understand it enough). That wrapQtAppsHook was introduced by 51d7803 btw and I don't really understand what it does anyway, so no hard feelings about your suggestions. |
changelog: https://bugs.scribus.net/changelog_page.php?version_id=106 Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
068ad7d
to
c39818d
Compare
Rebased to master and added your suggestions. Thanks for the feedback! @GrahamcOfBorg build scribusUnstable |
See https://hydra.nixos.org/build/96804884/download/1/nixpkgs/manual.html#sec-language-qt The part about using |
Great, I believe you've done all the appropriate checks then. |
@GrahamcOfBorg build scribusUnstable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds and executes for me on x86_64-linux NixOS 👍
Going to skip the x86_64-linux check since I've tested this. |
Thanks! |
changelog
Also changed the pname from
scribus-unstable
to justscribus
, as this seems to be the more widely used pattern.Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @