Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qbittorrent: use qt5's mkDerivation #66340

Merged
merged 1 commit into from Aug 8, 2019

Conversation

sam-willis
Copy link
Contributor

@sam-willis sam-willis commented Aug 8, 2019

Motivation for this change

See
#66339

Things done

See
#65399

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and executes for me. Verified that it was wrapped.

@worldofpeace worldofpeace changed the title qbittorrent: fixes issue 66339 qbittorrent: use qt5's mkDerivation Aug 8, 2019
@worldofpeace worldofpeace merged commit d94667d into NixOS:master Aug 8, 2019
@worldofpeace
Copy link
Contributor

Thanks for doing this @sam-willis.

In the force push I adjusted your commit message so it looked like all the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants