Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/httpd: extraSubservices cleanup #66492

Merged
merged 5 commits into from Aug 20, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Aug 11, 2019

Motivation for this change

services.httpd.extraSubservices is marked as deprecated so removing some of the final remnants of it.

@vcunat what did you want to do with the btmantis module? Should be pretty straight forward to change it into a full module like I've done with limesurvey, mediawiki, wordpress, etc... but if I'm going to do that I'd like to make sure there is someone to list as a maintainer (while I'm happy to rewrite the module if desired I'm not offering to be a maintainer 😄). The other option would be to drop it because it isn't being maintained. Please let me know what you'd like.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse aanderse changed the title Extra subservice cleanup nixos/httpd: extraSubservices cleanup Aug 11, 2019
@vcunat
Copy link
Member

vcunat commented Aug 12, 2019

btmantis: from my point of view it was a one-time experiment, and I haven't really used it. Theoretically, @tohl might be interested, but it seems more likely that noone will be.

@aanderse
Copy link
Member Author

@vcunat thanks for the clarification. We'll let this stew a few days and then merge unless @tohl says otherwise I guess then.

@ghost
Copy link

ghost commented Aug 13, 2019 via email

@aanderse
Copy link
Member Author

@tohl no problem, thanks!
@vcunat looking to you for final review and merge if you have the time.

@vcunat
Copy link
Member

vcunat commented Aug 13, 2019

Better not me. I'm relatively scarce on time, and my involvement with http services has been almost non-existent, so I'll prefer working on other nixpkgs stuff.

@aanderse
Copy link
Member Author

@GrahamcOfBorg test php-pcre

@adisbladis
Copy link
Member

👍 on removing unmaintained cruft!

I would like us to consider what we can do about making web services more generic.

I have a feeling all Python applications using wsgi could be abstracted in a way that allows the end user of the module to plug it into any web server that supports the wsgi protocol.

The same goes for cgi, reverse proxies and so on.

@aanderse
Copy link
Member Author

@adisbladis one thought I had was that the nginx module has some large advantages over httpd in that the virtualHosts option in nginx is an attribute set and httpd is stuck with a list. If httpd and nginx module options were made more similar (or at least compatible) I think that's one way to make web services more generic (though not the only way).

I'm planning on putting in a PR to migrate the services.httpd.virtualHosts to an attribute set like nginx, and possibly some other changes to make the two option sets more similar. Let me know if you're interested in that possible PR, or if you have a better idea for making web services more generic as that is a topic I'm quite interested in.

@aanderse aanderse merged commit 249b4ad into NixOS:master Aug 20, 2019
@aanderse aanderse deleted the extra-subservice-cleanup branch August 20, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants