Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "LTS Haskell 14.0" #66493

Closed
wants to merge 1 commit into from
Closed

Conversation

timokau
Copy link
Member

@timokau timokau commented Aug 11, 2019

Reverts #66468. Breaks eval, reverting for now. CC @peti.

@grahamc
Copy link
Member

grahamc commented Aug 11, 2019

cc @worldofpeace

@grahamc
Copy link
Member

grahamc commented Aug 11, 2019

note ofborg will probably fail anyway, since it first checks master.

@worldofpeace
Copy link
Contributor

Could we manually edit the file? I'm guessing something's up with the generation.
If not revert is fine, I'd expect @peti to respond accordingly.

cc @infinisil

@timokau
Copy link
Member Author

timokau commented Aug 11, 2019

Its most likely c4d3214 in particular, so maybe its enough to revert that. But that could lead to regressions. Seems safest to revert completely until @peti can look into it.

@infinisil
Copy link
Member

I'll take a look to see if it's easily fixable

@infinisil
Copy link
Member

Ah, the problem is that while @peti fixed the package being broken with c4d3214, he didn't remove hpack from the list of packages marked as broken, meaning when hackage-packages.nix was regenerated, it still ended up being marked as broken

I can fix this manually, PR(s) incoming in a bit

@infinisil infinisil mentioned this pull request Aug 11, 2019
@timokau
Copy link
Member Author

timokau commented Aug 11, 2019

Superseded by #66495.

@timokau timokau closed this Aug 11, 2019
@grahamc grahamc deleted the revert-66468-haskell-updates branch August 11, 2019 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants