Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yubikey-personalization-gui: install man, desktop files and icons #66489

Merged
merged 1 commit into from Sep 23, 2019
Merged

yubikey-personalization-gui: install man, desktop files and icons #66489

merged 1 commit into from Sep 23, 2019

Conversation

offlinehacker
Copy link
Contributor

Motivation for this change

Nices integration with desktop environments

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg eval

worldofpeace
worldofpeace suggested changes Aug 11, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more files you could be installing.

See various other build expression in other distros

The pkgbuild looked most correct to me.

@offlinehacker
Copy link
Contributor Author

I agree, but it's start. Do you want me to open issue for improvements?

@offlinehacker
Copy link
Contributor Author

I will add PNG file still, as that one should really be copied

@worldofpeace
Copy link
Contributor

I agree, but it's start. Do you want me to open issue for improvements?

I thought we could just copy what archlinux was doing 😄
It looks very complete.

@offlinehacker
Copy link
Contributor Author

will do 🙂

@offlinehacker offlinehacker force-pushed the pkgs/yubikey-personalization-gui/desktop-file branch from 3f0ebae to 8e9febb Compare September 23, 2019 21:13
@offlinehacker offlinehacker changed the title yubikey-personalization-gui: install desktop file yubikey-personalization-gui: install man, desktop files and icons Sep 23, 2019
@offlinehacker
Copy link
Contributor Author

Should be good now, thanks!

worldofpeace
worldofpeace approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things tested.

  1. icons converted correct, appear fine ✔️
  2. can view man page with man ✔️
  3. can launch application from desktop file and has icons ✔️

@worldofpeace worldofpeace merged commit 999acbf into NixOS:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@offlinehacker @worldofpeace