Use |LayoutBox::ContentLogicalHeight| value for atomic inline FlexBox. #18362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 10, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1746507
branch
3 times, most recently
from
b2eb45e
to
f809127
Compare
Before this CL, |LayoutBox::ComputeIntrinsicLogicalContentHeightUsing| returns zero intrinsic size defined in |LayoutBox::IntrinsicSize|, when atomic inline level flexbox's height is specified with 'height: min-content'. Per spec, https://drafts.csswg.org/css-sizing/#valdef-width-min-content, "min-content If specified for the inline axis, use the min-content inline size; otherwise compute to auto.", 'height' property specified with min-content should compute to 'auto', i.e. the content's intrinsic size. Bug: 959551 Change-Id: I798a07670036072bfd47bddb6bb0f88347eaa929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746507 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Joonghun Park <pjh0718@gmail.com> Cr-Commit-Position: refs/heads/master@{#687203}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1746507
branch
from
f809127
to
b712466
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this CL, |LayoutBox::ComputeIntrinsicLogicalContentHeightUsing|
returns zero intrinsic size defined in |LayoutBox::IntrinsicSize|,
when atomic inline level flexbox's height is specified with
'height: min-content'.
Per spec, https://drafts.csswg.org/css-sizing/#valdef-width-min-content,
"min-content
If specified for the inline axis, use the min-content inline size;
otherwise compute to auto.",
'height' property specified with min-content should compute to 'auto',
i.e. the content's intrinsic size.
Bug: 959551
Change-Id: I798a07670036072bfd47bddb6bb0f88347eaa929
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746507
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Joonghun Park <pjh0718@gmail.com>
Cr-Commit-Position: refs/heads/master@{#687203}