Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.zarith: enable for OCaml 4.08 #66333

Merged
merged 1 commit into from Aug 15, 2019
Merged

ocamlPackages.zarith: enable for OCaml 4.08 #66333

merged 1 commit into from Aug 15, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Aug 8, 2019

Motivation for this change

Current derivation does not work for OCaml 4.08.

cc #65632

I’ve successfully built lem and sail after this change: the findlib hook correctly sets the CAML_LD_LIBRARY_PATH environment variable.

ping @thoughtpolice

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer mentioned this pull request Aug 8, 2019
Merged
10 tasks
@vbgl vbgl merged commit 3cc99ee into NixOS:master Aug 15, 2019
@vbgl vbgl deleted the ocaml-zarith-fix branch August 15, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @thoughtpolice