nixos/prometheus2: replace alertmanagerURL with new alertmanagers option #66476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg test prometheus2 |
philandstuff
approved these changes
Aug 11, 2019
Ma27
approved these changes
Aug 12, 2019
There was a problem hiding this comment.
As prometheus2 doesn't seem to support the old option, I guess the removal and change here is perfectly fine.
However I'd wait for another reviewer to merge as my stuff is mostly on NixOS 19.03 where I (admittedly) still use prometheus v1, so I don't have an environment where I can quickly test this 😅
Prometheus2 does no longer support the command-line flag to specify an alertmanager. Instead it now supports both service discovery and configuration of alertmanagers in the alerting config section. Simply mapping the previous option to an entry in the new alertmanagers section is not enough to allow for complete configurations of an alertmanager. Therefore the option alertmanagerURL is no longer used and instead a full alertmanager configuration is expected.
WilliButz
force-pushed
the
fix-prometheus-alertmanager-option
branch
from
43e7cc5
to
a8847c8
Compare
fpletz
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Prometheus2 does no longer support the command-line flag to specify
an alertmanager. Instead it now supports both service discovery and
configuration of alertmanagers in the alerting config section.
Simply mapping the previous option to an entry in the new alertmanagers
section is not enough to allow for complete configurations of an
alertmanager.
For example in a setup where an alertmanager runs under the same subdomain as prometheus but under a seperate path, this needs to be configured in the alerting section of the prometheus config and currently the module does not provide this functionality.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)cc @basvandijk @andir @fpletz