Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nylas-mail-bin: drop package which is no longer supported upstream #66478

Merged
merged 1 commit into from Aug 11, 2019

Conversation

aanderse
Copy link
Member

Motivation for this change

#65657

I didn't bother putting in any release notes because the package seems to have been broken for some time 🤷‍♂️

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Contributor

I didn't bother putting in any release notes because the package seems to have been broken for some time man_shrugging

Sounds good @aanderse, can you add a throw to aliases.nix?

@aanderse
Copy link
Member Author

@worldofpeace right... thanks for always being on the ball 😄

@worldofpeace
Copy link
Contributor

@worldofpeace right... thanks for always being on the ball smile

Thanks, I try to be 😄

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

$ nix-build -A nylas-mail-bin                                                                                                                                        
error: deprecated in 2019-09-11: abandoned by upstream

@worldofpeace worldofpeace merged commit bddce34 into NixOS:master Aug 11, 2019
@aanderse aanderse deleted the nylas-mail branch August 11, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants