Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-expand: 0.4.12 -> 0.4.13 #66485

Merged
merged 1 commit into from Aug 16, 2019
Merged

cargo-expand: 0.4.12 -> 0.4.13 #66485

merged 1 commit into from Aug 16, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Aug 11, 2019 •
edited

Motivation for this change

Update cargo-expand to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jonringer
jonringer reviewed Aug 11, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't seem to be usable by default:

[nix-shell:/home/jon/.cache/nix-review/pr-66485]$ ./results/cargo-expand/bin/cargo-expand --help
error: no such subcommand: `+nightly`

@xrelkd
Copy link
Contributor Author

xrelkd commented Aug 12, 2019

cargo-expand is a subcommand for cargo. You need to invoke cargo-expand via cargo command.
To test the binary files in ./result/bin, consider the following commands:

[john@nixos:~/result/bin] PATH=.:$PATH cargo expand --version
cargo-expand 0.4.13

@jonringer

@jonringer
Copy link
Contributor

ah, so it's like the git-xxxx commands. I apologize for my ignorance :)

@xrelkd
Copy link
Contributor Author

xrelkd commented Aug 12, 2019

@jonringer Thanks for the review.

@xrelkd
Copy link
Contributor Author

xrelkd commented Aug 13, 2019

@jonringer Thanks for the review. Can we merge this PR?

@jonringer
Copy link
Contributor

I don't have commit access, otherwise i would do a little test, then merge if successful.

Sorry bud :(

@marsam marsam merged commit 46c64da into NixOS:master Aug 16, 2019
@xrelkd
Copy link
Contributor Author

xrelkd commented Aug 16, 2019

@jonringer @marsam Thank you!!

@xrelkd xrelkd deleted the update/cargo-expand branch August 16, 2019 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @jonringer @marsam