Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia-x11 - apply only patches for the right kernel #66421

Closed
wants to merge 1 commit into from
Closed

nvidia-x11 - apply only patches for the right kernel #66421

wants to merge 1 commit into from

Conversation

nek0
Copy link
Contributor

@nek0 nek0 commented Aug 10, 2019 •
edited

Motivation for this change

The nvidiaLegacy390 driver failed building on stable kernel (4.19) due to patches for 5.1 kernel
being applied. Should fix #65937.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @baracoder

@nek0 nek0 changed the title apply only patches for the right kernel nvidiax11 - apply only patches for the right kernel Aug 10, 2019
@nek0 nek0 changed the title nvidiax11 - apply only patches for the right kernel nvidia-x11 - apply only patches for the right kernel Aug 10, 2019
@eadwu
Copy link
Member

eadwu commented Aug 10, 2019

Would only fix the issue for 4.19 while it would still fail on 5.x since the patch is still being applied. If the patch is still needed on 5.2 editing the patch so that it applies cleanly would be the solution but if it isn't needed just drop it.

@ambrop72
Copy link
Contributor

ambrop72 commented Oct 5, 2019

This should be closed since #69851 fixed it the right way.

@nek0
Copy link
Contributor Author

nek0 commented Oct 5, 2019

OK. Closing. Thanks for all the effort.

@nek0 nek0 closed this Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nvidiaLegacy390 fails to build
3 participants
@nek0 @eadwu @ambrop72