Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/ibus: do not default-install ibus-qt #66449

Merged
merged 1 commit into from Aug 12, 2019
Merged

nixos/ibus: do not default-install ibus-qt #66449

merged 1 commit into from Aug 12, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Aug 10, 2019

Motivation for this change

ibus-qt has not seen a release in 5 years and is only relevant for Qt
4.x, which is becoming more and more rare. Using my current laptop as a
data point, ibus-qt is the only dependency left that drags in qt-4.8.7.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ttuegel

@delroth
nixos/ibus: do not default-install ibus-qt
67d1cf4 
ibus-qt has not seen a release in 5 years and is only relevant for Qt
4.x, which is becoming more and more rare. Using my current laptop as a
data point, ibus-qt is the only dependency left that drags in qt-4.8.7.
@delroth
Copy link
Contributor Author

delroth commented Aug 10, 2019

(Note: this does not impact QT_IM_MODULE = "ibus"; since this env var references a Qt platform input plugin. Qt 5.x on NixOS ships with the ibus plugin, e.g. /nix/store/hkyzwp8xsa8psk8vbivhqjab0qa1j983-qtbase-5.12.0-bin/lib/qt-5.12/plugins/platforminputcontexts/libibusplatforminputcontextplugin.so)

@delroth
Copy link
Contributor Author

delroth commented Aug 10, 2019

(x-link #33248)

worldofpeace
worldofpeace reviewed Aug 12, 2019
View reviewed changes
nixos/modules/i18n/input-method/ibus.nix
@@ -55,7 +55,7 @@ in

# Without dconf enabled it is impossible to use IBus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this change, but I'm certain that what should have been done here is

services.dbus.packages = [ pkgs.gnome3.dconf ];

since config.system.path gets added to that option automatically.

@worldofpeace worldofpeace merged commit e9e165f into NixOS:master Aug 12, 2019
@worldofpeace
Copy link
Contributor

Thanks @delroth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@delroth @worldofpeace