Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libressl_3_0: init at 3.0.0 #66452

Merged
merged 1 commit into from Aug 20, 2019
Merged

libressl_3_0: init at 3.0.0 #66452

merged 1 commit into from Aug 20, 2019

Conversation

ruuda
Copy link
Contributor

@ruuda ruuda commented Aug 10, 2019

Motivation for this change

LibreSSL 3.0.0 was released upstream.

LibreSSL 2.8, which first shipped in OpenBSD 6.4 is still supported, as OpenBSD 6.4 was released less than a year ago, so there is no need to remove it yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice @fpletz @globin

jonringer
jonringer approved these changes Aug 11, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
binaries seem to work
leaf packge

@risicle
Copy link
Contributor

risicle commented Aug 11, 2019

WFM non-nixos linux x86_64, macos 10.13. openssl speed completes successfully.

@ajs124
Copy link
Member

ajs124 commented Aug 12, 2019

Why are we not defaulting to this version and staying on 2_9 instead? Is there software that is not compatible with this new release? Any other reasons?

@ruuda
Copy link
Contributor Author

ruuda commented Aug 12, 2019

Why are we not defaulting to this version and staying on 2_9 instead? Is there software that is not compatible with this new release? Any other reasons?

As far as I am aware, there are no incompatibilities. 2.9 is still supported, so there is no pressure to upgrade immediately. (Although some entries in the change log sound quite severe and I am not whether 2.9 is affected.) On the other hand, I don’t see any downsides to upgrading the default, apart from more rebuilds.

@thoughtpolice
Copy link
Member

@GrahamcOfBorg build libressl_3_0

@thoughtpolice thoughtpolice self-assigned this Aug 20, 2019
thoughtpolice
thoughtpolice approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just bump the default in a new PR, but in the mean time this looks good. Thank you!

@thoughtpolice thoughtpolice merged commit bc18550 into NixOS:master Aug 20, 2019
@ruuda ruuda deleted the libressl-3.0 branch October 6, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@jonringer jonringer jonringer approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

Assignees

@thoughtpolice thoughtpolice

Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ruuda @risicle @ajs124 @thoughtpolice @jonringer