Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

environment.profiles: fix order of profiles and PATH #66425

Merged
merged 1 commit into from Aug 13, 2019
Merged

environment.profiles: fix order of profiles and PATH #66425

merged 1 commit into from Aug 13, 2019

Conversation

Gerschtli
Copy link
Contributor

Motivation for this change

This change is needed because the order of profiles correlate to the
order in PATH, therefore /etc/profiles/per-user/$USER always appeared
after the system packages directories.

Resolves nix-community/home-manager#550.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Gerschtli
environment.profiles: fix order of profiles
33c834f 
This change is needed because the order of profiles correlate to the
order in PATH, therefore "/etc/profiles/per-user/$USER" always appeared
after the system packages directories.
@matthewbauer matthewbauer merged commit 329e097 into NixOS:master Aug 13, 2019
@Gerschtli Gerschtli deleted the fix/path-order branch August 13, 2019 22:55
@matthewbauer matthewbauer mentioned this pull request Aug 14, 2019
Closed
@matthewbauer
Copy link
Member

Should this be backported?

@Gerschtli
Copy link
Contributor Author

In my opinion, I think it should.. Seems to me like a bug, which was existant since the beginning.

@matthewbauer
Copy link
Member

Ok cherry picked to release-19.03 in 2aead24

@Gerschtli
Copy link
Contributor Author

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

problems with PATH order, when using as nixos-module.
2 participants
@Gerschtli @matthewbauer