Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh-better-npm-completion: init at 2017-07-02 #66428

Closed

Conversation

Gerschtli
Copy link
Contributor

Motivation for this change

Init zsh plugin zsh-better-npm-completion at last available commit, unfortunately there are now tags in the upstream repo.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Gerschtli Gerschtli force-pushed the add/zsh-better-npm-completion branch from d7f7d82 to 92cf96c Compare August 29, 2019 21:33

meta = with stdenv.lib; {
description = "Better completion for npm";
homepage = https://github.com/lukechilds/zsh-better-npm-completion;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = https://github.com/lukechilds/zsh-better-npm-completion;
homepage = "https://github.com/lukechilds/zsh-better-npm-completion";


installPhase = ''
install -D -m 0444 zsh-better-npm-completion.plugin.zsh \
$out/share/zsh/plugins/zsh-better-npm-completion/zsh-better-npm-completion.plugin.zsh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$out/share/zsh/plugins/zsh-better-npm-completion/zsh-better-npm-completion.plugin.zsh
${placeholder "out"}/share/zsh/plugins/zsh-better-npm-completion/zsh-better-npm-completion.plugin.zsh

@Gerschtli Gerschtli closed this Aug 15, 2020
@Gerschtli Gerschtli deleted the add/zsh-better-npm-completion branch August 15, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants