Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetbrains.rider: 2019.1.2 -> 2019.2 #66426

Closed
wants to merge 1 commit into from

Conversation

jirkadanek
Copy link
Member

@jirkadanek jirkadanek commented Aug 10, 2019

Motivation for this change

New major version of the IDE.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@rixed
Copy link
Contributor

rixed commented Nov 17, 2019

cc @Mic92 (also in maintainers)

@rixed
Copy link
Contributor

rixed commented Nov 17, 2019

Also tested that it build and run on nixos on linux on unstable as of c196652.

@bennofs
Copy link
Contributor

bennofs commented Jan 24, 2020

Sorry, it seems that this PR got lost. Master now already has rider 2019.3.1, so this is no longer relevant.

@bennofs bennofs closed this Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants