Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pure-prompt: init at 1.12.0 #66427

Merged
merged 3 commits into from May 26, 2020
Merged

pure-prompt: init at 1.12.0 #66427

merged 3 commits into from May 26, 2020

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Aug 10, 2019 •
edited

Motivation for this change

This PR adds a package for pure, a "pretty, minimal and fast ZSH prompt".

Usage example that might be useful to users and reviewers:

{
  programs.zsh = {
    interactiveShellInit = ''
      fpath+=("${pkgs.pure-prompt}/share/zsh/site-functions")
    '';
    promptInit = ''
      if [ "$TERM" != dumb ]; then
        autoload -U promptinit && promptinit && prompt pure
      fi
    '';
  };
}
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pacien
Copy link
Contributor Author

pacien commented Aug 10, 2019

@GrahamcOfBorg build pure-prompt

@Gerschtli
Copy link
Contributor

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on amd64
  • executables tested on ARCHITECTURE
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected
  • patches that are remotely available are fetched with fetchpatch

Gerschtli
Gerschtli approved these changes Aug 10, 2019
View reviewed changes
pkgs/shells/zsh/pure-prompt/default.nix Outdated Show resolved Hide resolved
@pacien
Copy link
Contributor Author

pacien commented Aug 10, 2019

@Gerschtli Thanks for your review. The requested change has been amended.

@pacien pacien changed the title pure-prompt: init at 1.10.3 pure-prompt: init at 1.11.0 Mar 5, 2020
@Pablo1107
Copy link
Contributor

I just tested (and updated) this package on my NixOS environment, it works fine. I'll try it on Ubuntu in the following week to test on a non-NixOS environment.

@pacien @Pablo1107
pure-prompt: init at 1.12.0
db97cb3 
Co-authored-by: pablo1107 <dealberapablo07@gmail.com>
@pacien
Copy link
Contributor Author

pacien commented May 9, 2020

Updated to 1.12.0 and added @Pablo1107 as maintainer (from pacien#1)

@pacien pacien changed the title pure-prompt: init at 1.11.0 pure-prompt: init at 1.12.0 May 9, 2020
@Lassulus Lassulus merged commit 0300b47 into NixOS:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerschtli Gerschtli Gerschtli approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pacien @Gerschtli @Pablo1107 @Lassulus