Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A change detector test for the dynamics of the solar system #2268

Merged
merged 4 commits into from
Aug 8, 2019

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Aug 7, 2019

No description provided.

{/*separation_per_orbit=*/0.033516 * ArcSecond,
/*inclination_drift_per_orbit=*/0.000014 * ArcSecond,
/*longitude_of_ascending_node_drift_per_orbit=*/0.010286 * ArcSecond,
/*argument_of_periapsis_drift_per_orbit=*/std::nullopt}},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make argument_of_periapsis_drift_per_orbit unconditional (but you might want to use longitude_of_periapsis_drift_per_orbit instead).
Same for longitude_of_ascending_node_drift_per_orbit.

They can be a bit ill-conditioned, but since the point is to have a change detector, let's look at them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. As discussed, sticking to argument_of_periapsis_drift_per_orbit.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Aug 8, 2019
@pleroy pleroy merged commit 8e0d73e into mockingbirdnest:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants