Report image url for oversized/unoptimized images #18337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 8, 2019
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1741958
branch
3 times, most recently
from
e6be48d
to
bf6f18e
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1741958
branch
4 times, most recently
from
c84b55c
to
d3e5c77
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1741958
branch
3 times, most recently
from
a45edef
to
8b5f819
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1741958
branch
from
8b5f819
to
e84c25e
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1741958
branch
from
e84c25e
to
7dbb9cb
Compare
Add image url to FeaturePolicyViolationReportBody when there is a oversized/unoptimized image feature policy violated. Previously the fileSource field in report is set to null when policy is violated. The effect is achieved by letting LocationReportBody represents both a location in JavaScript source code and a location of a general resource, e.g. a image. Because image does not have line number and column number, these attrs are represented in optional value, and LocationReportBody now saves pieces of actual information it needs to generate the report, instead of a reference to SourceLocation. Bug: 989701 Change-Id: Ibe88f07e7fa93c3d54b17380f8627221c119e106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741958 Reviewed-by: Ian Clelland <iclelland@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#687829}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1741958
branch
from
7dbb9cb
to
60f0920
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add image url to FeaturePolicyViolationReportBody when there is a
oversized/unoptimized image feature policy violated. Previously the
fileSource field in report is set to null when policy is violated.
The effect is achieved by letting LocationReportBody represents both
a location in JavaScript source code and a location of a general
resource, e.g. a image. Because image does not have line number and
column number, these attrs are represented in optional value, and
LocationReportBody now saves pieces of actual information it needs
to generate the report, instead of a reference to SourceLocation.
Bug: 989701
Change-Id: Ibe88f07e7fa93c3d54b17380f8627221c119e106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741958
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#687829}