Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/postgresql: fix quoted queries #66401

Merged
merged 1 commit into from Aug 11, 2019
Merged

nixos/postgresql: fix quoted queries #66401

merged 1 commit into from Aug 11, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Aug 9, 2019

Motivation for this change

Such as meta.sr.ht and this.should.work.now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@eadwu eadwu mentioned this pull request Aug 10, 2019
Merged
10 tasks
@danbst danbst merged commit 329fa4b into NixOS:master Aug 11, 2019
@danbst
Copy link
Contributor

danbst commented Aug 11, 2019

tested postgresql_9_4 and ./nixos/tests/nextcloud/with-postgresql-and-redis.nix.

It may be that somebody had already performed the escaping, like ensureDatabases = [ ''"foo.bar"'' ];... but this wasn't yet officially released... so, bad luck for them!

@eadwu
Copy link
Member Author

eadwu commented Aug 11, 2019 •
edited

I think just nobody used the irregular naming that would require the usage of quotes so I probably nobody would be affected by it since even if they escaped it before it would've resulted in a bad query.

datname = '${database}' -> datname = '"foo.bar"'

@eadwu eadwu deleted the postgresql/fix-quoted-query branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse left review comments

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice thoughtpolice is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @danbst @aanderse