ec2-instance-connect-cli: init at 1.0.0 #66466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefloweringash
force-pushed
the
ec2-instance-connect-cli
branch
from
704c25d
to
4bd4d6f
Compare
thefloweringash
force-pushed
the
ec2-instance-connect-cli
branch
from
4bd4d6f
to
27ced7d
Compare
doronbehar
approved these changes
Feb 23, 2020
|
Sorry for requesting the review. I don't know, how to undo that. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
doronbehar
reviewed
Apr 7, 2021
| @@ -808,6 +808,8 @@ in | |||
|
|
|||
| dpt-rp1-py = callPackage ../tools/misc/dpt-rp1-py { }; | |||
|
|
|||
| ec2-instance-connect-cli = python3Packages.callPackage ../tools/security/ec2-instance-connect-cli { }; | |||
There was a problem hiding this comment.
There's a sort of agreement that using callPackage in all-packages.nix is better vs this method. This would require importing python3Packages inside the expression.
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Package is included now in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Tool for using #66463. Requires updated botocore (in #66465).
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @