Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Amazon released EC2 Instance Connect that allows SSH authentication to be attached to Amazon's authentication system (IAM). They provide packages for Ubuntu and their first party linux. This is an implementation for NixOS.
A note about the implementation: it's a lot of shell scripting, where the scripts are written in a style where the majority (but not all!) of external commands are written with absolute paths. To make this work, these need to be rewritten somehow. I elected to replace the call sites with their resolved path by looking up the path in a constructed
lib.makeBinPath
. For the few that aren't absolute, I also added coreutils to the PATH in the wrapper.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @