[cookie-store] Attempt of deflake remaining service worker tests #18340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to #18324 This change by itself isn't sufficient to deflake the two tests.
Move the event handler registration to the top scope of the service worker (Chrome warning: "Event handler of ... event must be added on the initial evaluation of worker script.").
|
Well, we got lucky this time -- stability check is green. But locally I can still get some flaky results from Chrome Dev (with experimental features enabled) by |
|
ping @inexorabletash |
inexorabletash
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the two remaining tests that were not fixed in #18324 .
Unfortunately, the two tests still seem a bit flaky with all the speculative fixes.