Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.dask: 1.2.2 -> 2.2.0 #66348

Merged
merged 3 commits into from Aug 10, 2019
Merged

Conversation

pierothebear
Copy link
Contributor

@pierothebear pierothebear commented Aug 8, 2019

Motivation for this change

This Pull Request upgrades the dask package to 2.2.0.

Things done

Updated the default.nix of the package, compiled on MacOS X and obtained the sha256 number.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @
@kalbasit

@kalbasit kalbasit changed the title [python3][dask] update dask to 2.2.0 pythonPackages.dask: 1.2.2 -> 2.2.0 Aug 8, 2019
@kalbasit
Copy link
Member

kalbasit commented Aug 8, 2019

@GrahamcOfBorg build python2Packages.dask python3Packages.dask

@kalbasit
Copy link
Member

kalbasit commented Aug 8, 2019

dask does not work on Py2

@GrahamcOfBorg build python3Packages.dask

@kalbasit kalbasit self-assigned this Aug 9, 2019
@kalbasit
Copy link
Member

kalbasit commented Aug 9, 2019

Missing fsspec propagatedBuildInputs. I'll be working with @pierothebear to fix this offline.

@kalbasit
Copy link
Member

kalbasit commented Aug 9, 2019

@GrahamcOfBorg build python3Packages.dask python3Packages.fsspec

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quite a few breakages, not all of them your fault

[17 built (7 failed), 18 copied (559.4 MiB), 70.8 MiB DL]
error: build of '/nix/store/hq2i8rff4kjnk5ix5ijv7z8hnzd631wq-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/66348
1 package are marked as broken and were skipped:
python37Packages.imgaug

11 package failed to build:
python37Packages.aplpy python37Packages.blaze python37Packages.dask-glm python37Packages.dask-ml python37Packages.dask-xgboost python37Packages.datashader python37Packages.intake python37Packages.odo python37Packages.starfish python37Packages.streamz python37Packages.sunpy

15 package were build:
python37Packages.caffe python37Packages.dask python37Packages.dask-image python37Packages.dask-jobqueue python37Packages.dask-mpi python37Packages.distributed python37Packages.fsspec python37Packages.glymur python37Packages.image-match python37Packages.pims python37Packages.pyfftw python37Packages.rl-coach python37Packages.scikitimage python37Packages.slicedimage python37Packages.stumpy

@kalbasit
Copy link
Member

I checked all the failures you reported against master, and only python37Packages.intake is passing there. I'll fix it here then.

@kalbasit kalbasit mentioned this pull request Aug 10, 2019
10 tasks
@kalbasit
Copy link
Member

Fixing intake is proving to take longer than expected. I'll get it done in #66412.

@kalbasit kalbasit merged commit 77eaa86 into NixOS:master Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants