Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subversion: 1.9.9 -> 1.9.12, 1.10.4 -> 1.10.6 [19.03 backport] #66440

Merged
merged 1 commit into from Aug 21, 2019
Merged

subversion: 1.9.9 -> 1.9.12, 1.10.4 -> 1.10.6 [19.03 backport] #66440

merged 1 commit into from Aug 21, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Aug 10, 2019 •
edited

Motivation for this change

Fix for CVE-2018-11782 and CVE-2019-0203.
Backport of #66439.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse aanderse added the 8.has: port to stable A PR already has a backport to the stable release. label Aug 10, 2019
@aanderse aanderse changed the title subversion: 1.9.9 -> 1.9.12, 1.10.4 -> 1.10.6 subversion: 1.9.9 -> 1.9.12, 1.10.4 -> 1.10.6 [19.03 backport] Aug 10, 2019
@ofborg ofborg bot requested review from edolstra and lovek323 August 10, 2019 14:01
@aanderse
Copy link
Member Author

@GrahamcOfBorg test subversion

@vcunat
Copy link
Member

vcunat commented Aug 10, 2019

Hmm, we do have nixos/tests/subversion.nix but I can't see it linked as an attribute.

@aanderse
Copy link
Member Author

Hmm, we do have nixos/tests/subversion.nix but I can't see it linked as an attribute.

Yeah, it looks like it should be removed because it references a file which doesn't exist and it uses the deprecated services.httpd.extraSubservices.

@vcunat
Copy link
Member

vcunat commented Aug 10, 2019

Well, 19.03 is a dead-end branch, so we don't really need to clean up there, but on master it seems to be the same.

@aanderse
Copy link
Member Author

Yeah, sorry, I meant in master. I'll look into that over the next few days likely.

@risicle
Copy link
Contributor

risicle commented Aug 11, 2019

WFM macos 10.13

@aanderse aanderse requested a review from andir August 11, 2019 22:09
@aanderse aanderse merged commit 94b5774 into NixOS:release-19.03 Aug 21, 2019
@aanderse aanderse deleted the subversion-backport branch August 21, 2019 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@lovek323 lovek323 Awaiting requested review from lovek323

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @vcunat @risicle