Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgsi686Linux.qt5.qtbase: fix build #66335

Merged
merged 1 commit into from Aug 9, 2019
Merged

pkgsi686Linux.qt5.qtbase: fix build #66335

merged 1 commit into from Aug 9, 2019

Conversation

averelld
Copy link
Contributor

@averelld averelld commented Aug 8, 2019 •
edited by veprbl

Motivation for this change

Makes pkgsi686Linux.qt5.qtbase build again (and dependents, such as wine / lutris), while leaving most everything else alone.

Resolves: #63829

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@averelld averelld requested a review from ttuegel as a code owner August 8, 2019 16:40
@ofborg ofborg bot requested review from periklis and qknight August 8, 2019 16:54
@veprbl veprbl requested a review from Ericson2314 August 8, 2019 17:56
@averelld averelld force-pushed the pkgsi686Linux.qt5.qtbase-build-fix branch from 8ee8f4a to 5c6efa5 Compare August 8, 2019 18:14
@averelld averelld force-pushed the pkgsi686Linux.qt5.qtbase-build-fix branch from 5c6efa5 to 658ffb0 Compare August 8, 2019 18:15
ttuegel
ttuegel approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ttuegel ttuegel merged commit bd5ecb5 into NixOS:master Aug 9, 2019
@averelld averelld deleted the pkgsi686Linux.qt5.qtbase-build-fix branch August 9, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@ttuegel ttuegel ttuegel approved these changes

@periklis periklis Awaiting requested review from periklis

@qknight qknight Awaiting requested review from qknight

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkgsi686Linux.qt5.qtbase fails to build
4 participants
@averelld @veprbl @ttuegel @Ericson2314