pgbouncer: use c-ares for name resolution #66336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to pgbouncer README.md file c-ares is the prefered way to resolve names for pgbouncer 1.10+: https://github.com/pgbouncer/pgbouncer/blob/master/README.md#dns-lookup-support The previous method (evdns) did not support EDNS0 and SOA lookups.
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
|
Anyone could see if this can be merged or has issues, apologizes for referencing you @danbst but you seem to be around postgres related PRs. |
|
interesting, does default APT pgbouncer package use c-ares? Can't find source for that |
|
@danbst I just checked on centos from the postgresql.org official repo and it does include c-ares: On FreeBSD it is defined as an option: https://svnweb.freebsd.org/ports/head/databases/pgbouncer/Makefile?revision=507877&view=markup#l29 but then the version there is 1.9.0, but then according to the table I linked initially, the c-ares became the best DNS resolution method from version 1.10.0 onward, all other ones has some limitations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to pgbouncer README.md file c-ares is the
prefered way to resolve names for pgbouncer 1.10+:
https://github.com/pgbouncer/pgbouncer/blob/master/README.md#dns-lookup-support
The previous method (evdns) did not support EDNS0 and SOA lookups.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @ (no maintainers listed)