Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages_latest.campl4: init at 4.08+1 #66343

Merged
merged 1 commit into from Aug 9, 2019
Merged

ocamlPackages_latest.campl4: init at 4.08+1 #66343

merged 1 commit into from Aug 9, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 8, 2019 •
edited

Motivation for this change

Released yesterday.

Allows for buildOcaml to be used with ocamlPackages_latests.*.

May have to retire using campl4 as part of buildOcaml after this, as they mentioned this will be the last release. https://github.com/ocaml/camlp4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vbgl @samuelrivas @nbp @aske

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build ocamlPackages_latest.zarith

@jonringer
Copy link
Contributor Author

Since the ocamlPackages_latest.* package set isn't a hydra jobset, a nix-review will return nothing. However, you can test on master:

nix-build -A ocamlPackages_latest.zarith # fails
git fetch origin pull/66343/head:campl4
git co campl4
nix-build -A ocamlPackages_latest.zarith # succeeds, but takes a while to build

@vbgl
Copy link
Contributor

vbgl commented Aug 9, 2019

This should not close #66333 which is still a useful change in the long term.

@vbgl
Copy link
Contributor

vbgl commented Aug 9, 2019

@GrahamcOfBorg build ocaml-ng.ocamlPackages_4_08.camlp4

@jonringer
Copy link
Contributor Author

agreed, I did not fully understand the implication when I first submitted the PR. Just that I fixed the original build in question

@vbgl vbgl merged commit 62a916d into NixOS:master Aug 9, 2019
@jonringer jonringer deleted the add-campl4-4.08 branch December 1, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @vbgl