Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clj-kondo: init at 2019.07.31-alpha #66344

Merged
merged 1 commit into from Aug 20, 2019
Merged

Conversation

jlesquembre
Copy link
Member

Motivation for this change

Add clj-kondo, a linter for clojure

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/how-to-compile-and-package-an-app-with-graalvm/3662/3

@jlesquembre
Copy link
Member Author

No idea why I'm getting that error from grahamcofborg, locally works

@jlesquembre
Copy link
Member Author

@volth you are right, it was the evaluation on Darwin
Thanks a lot for your help with this PR, now looks a lot better :)

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/53

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build clj-kondo

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/increase-ofborg-timeout/3762/1

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the help menus, builds for me 👍

@worldofpeace worldofpeace merged commit 83cc092 into NixOS:master Aug 20, 2019
@worldofpeace
Copy link
Contributor

@jlesquembre Thanks for your patience.

@jlesquembre jlesquembre deleted the clj-kondo branch August 20, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants