pythonPackages.pytest_3: drop #66376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pluggy>=0.9 introduced a breaking change to pytest_3, and is not feasible to keep pytest_3 around in nixpkgs. See: NixOS#64445
risicle
reviewed
Aug 10, 2019
|
|
||
| propagatedBuildInputs = [ | ||
| scipy | ||
| ]; | ||
|
|
||
| # Does not support pytest 4 https://github.com/carsonfarmer/fastpair/issues/14 | ||
| doCheck = false; |
|
Sigh. WFM on macos 10.13. I guess. |
jonringer
approved these changes
Aug 12, 2019
There was a problem hiding this comment.
nix-review passes on NixOS (1 broken on master)
diff LGTM
most binaries seem to work
[22 built (1 failed), 64 copied (129.0 MiB), 41.5 MiB DL]
error: build of '/nix/store/c72p5sradqfdlz9q4gxdc39yys1gwby0-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/66376
1 package failed to build:
python37Packages.sunpy
18 package were build:
bonfire datasette python27Packages.click-default-group python27Packages.fastpair python27Packages.modeled python27Packages.moretools python27Packages.robotframework-tools python27Packages.zeep python27Packages.zetup python37Packages.click-default-group python37Packages.fastpair python37Packages.matchpy python37Packages.modeled python37Packages.moretools python37Packages.pysonos python37Packages.robotframework-tools python37Packages.zeep python37Packages.zetup
jonringer
reviewed
Aug 12, 2019
There was a problem hiding this comment.
not related to your changes, but can you change bonfire and datasette to using python2, i get this error when trying to run them:
[nix-shell:~/.cache/nix-review/pr-66376-1]$ ./results/bonfire/bin/bonfire
Error in sitecustomize; set PYTHONVERBOSE for traceback:
ImportError: This package should not be accessible on Python 3. Either you are trying to run from the python-future src folder or your installation of python-future is corrupted.
...
[nix-shell:~/.cache/nix-review/pr-66376-1]$ ./results/bonfire/bin/bonfire
Error in sitecustomize; set PYTHONVERBOSE for traceback:
ImportError: This package should not be accessible on Python 3. Either you are trying to run from the python-future src folder or your installation of python-future is corrupted.
...
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
See: #64445 (comment)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @FRidh