Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/fuse: init #66480

Merged
merged 2 commits into from
Aug 14, 2019
Merged

nixos/fuse: init #66480

merged 2 commits into from
Aug 14, 2019
+41 −3

Conversation

primeos
Copy link
Member

@primeos primeos commented Aug 11, 2019 •
edited
Loading

Add a module for /etc/fuse.conf.
Fixes #30923.

This was requested multiple times now so it seems to be worth a module.

TODOs for review/discussion (optional, the current implementation already works and is ready to be merged):

  • Is the path/namespace ok? program.fuse loooks better, than e.g. fuse.* but I would assume that most program.* modules usually have an enable option.
  • Do we need an enable option? This could be useful to prevent fuse and fuse3 from being installed, avoid the suid binaries, and blacklist the kernel module (but it should remain enabled by default).
  • Should I move all fuse related logic into this module? I.e. from nixos/modules/profiles/base.nix and nixos/modules/security/wrappers/default.nix?
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@primeos
nixos/fuse: init

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
2473d90 
Add a module for /etc/fuse.conf.
Fixes NixOS#30923.
@primeos primeos requested a review from infinisil as a code owner August 11, 2019 14:21
@primeos primeos mentioned this pull request Aug 11, 2019
Closed
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 11, 2019
rasendubi
rasendubi reviewed Aug 12, 2019
View reviewed changes
Copy link
Member

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick. Otherwise, looks good.

@rasendubi
Copy link
Member

Do we need an enable option?
Should I move all fuse related logic into this module?

I would say "yes" to both:

  • programs.fuse name makes much more sense then
  • pulling all pieces together makes the module easier to understand

The module is fine to merge as is, though.

Looking through profiles/base.nix and security/wrappers I am not sure why profiles/base.nix puts fuse into systemPackages—security wrappers look like fuse and fuse3 binaries are always installed.

@primeos @rasendubi
Fix the indentation

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
62f7711 
Co-Authored-By: Alexey Shmalko <rasen.dubi@gmail.com>
@matthewbauer matthewbauer merged commit 3411c15 into NixOS:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasendubi rasendubi

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NixOS option for /etc/fuse.conf entries
3 participants
@primeos @rasendubi @matthewbauer