metabase: service module and test #66399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg test metabase |
infinisil
requested changes
Aug 9, 2019
|
Hehe, reviewed by multiple people at the same time |
aanderse
reviewed
Aug 10, 2019
|
@GrahamcOfBorg test metabase |
|
@GrahamcOfBorg test metabase |
mmahut
force-pushed
the
metabase
branch
2 times, most recently
from
b6e1eac
to
6e5f622
Compare
|
@GrahamcOfBorg test metabase |
aanderse
approved these changes
Aug 11, 2019
infinisil
reviewed
Aug 11, 2019
|
@GrahamcOfBorg test metabase |
|
Commits are a bit messed up, adding yourself as a maintainer should be the first one, and it shouldn't include other parts of the PR |
|
@infinisil sorry, my last force push did not go thought, here we go. :) |
|
@GrahamcOfBorg test metabase |
|
ping @infinisil @aanderse |
|
Awesome. If I could only ask one more thing it would be to drop the unused |
mmahut
force-pushed
the
metabase
branch
3 times, most recently
from
daac315
to
7ce6b15
Compare
aanderse
requested changes
Aug 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adding service module along with the test for metabase.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @schneefux @thoughtpolice