@GrahamcOfBorg build mandelbulber2

While it should work on Mac and Windows as well, since I don't have either to test it I haven't added it to the platforms, my thinking was that if someone needs it on that platform they can test it and make it work.

Apparently there are two flags to pass to the C compiler/preprocessor, into which I want a C string, hence I need to enclose the path in double-quotes. Make calls the C compiler in a shell, so I need to escape the double-quotes hence ("). The shell calling qmake does backslash expansion hence (\"); Nix strings do backslash expansion hence (\\\").

ping (triage) ... where are we at with this?

I have folded in the latest changes from jtojnar, and have asked upstream to patch example files buddhi1980/mandelbulber2#719 though that hasn't progressed yet. Apart from that I think that's all the comments addressed

@KoviRobi Please address bot failures when you get a chance.

Sure, though not sure how to interpret the failures, all I see is

grahamcofborg-eval

x86_64-linux	mandelbulber2
i686-linux	mandelbulber2
aarch64-linux	mandelbulber2

grahamcofborg-eval-check-meta

nix-env failed:

and it doesn't say much to me.

Looks like the bot just needed to be started again?

@aanderse I think this is ready to be merged? I have addressed all the comments, and the bot has managed to make everything pass.

@GrahamcOfBorg build mandelbulber2

@KoviRobi sorry for the delay, this PR slipped by me. Thanks for your patience and persistence!

@ivan @jtojnar any additional changes required on your part before merge?

@KoviRobi any idea on whenthe next upstream release is? That release will eliminate the need for your patch here as your patch was accepted upstream...

@aanderse I have just asked, apparently in about 2 weeks, so might be worth the wait until then

Now using the new version, 2.20 which has the hardcoded paths patch included

Whoops, I seem to have messed up something with the commits, I just wanted to squash it into a single commit (I think that's preferred in the nixpkgs manual), let me fix that

Sorry about the accidental mistake, I just did a git rebase -i HEAD~5 thinking that just leaving the extra commits as above won't change anything, but it did (probably should have used git rebase -i HEAD^5, I just didn't pay close enough attention to the difference between ~ and ^, now I know). This also then triggered a review request that I now don't know how to cancel, sorry ttuegel.

On the website and everywhere else, it seems to be referred as just mandelbulber. Would it make sense drop 2 from pname and attribute name? Also that is what it goes by on repology: https://repology.org/projects/?search=mandelbulber&maintainer=&category=&inrepo=&notinrepo=&repos=&families=&repos_newest=&families_newest=

I guess so, I just got the impression that it went by mandelbulber2 for the version 2 (https://repology.org/project/mandelbulber/versions), though it's not a fork and v1 is deprecated (https://sourceforge.net/projects/mandelbulber/files/). Don't know if there was a rewrite/redesign that made or other incompatibilities that made packaging the two separately worthwhile. But anyway we don't have a v1.

Great work, thanks.