Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-blackbox-exporter: 0.12.0 -> 0.14.0, run tests and check config #66470

Merged
merged 2 commits into from Aug 12, 2019
Merged

prometheus-blackbox-exporter: 0.12.0 -> 0.14.0, run tests and check config #66470

merged 2 commits into from Aug 12, 2019

Conversation

WilliButz
Copy link
Member

Motivation for this change

Update to the latest release, which now supports checking the config file.

Things done

The tests are now run, the config file is checked during eval and I added myself as maintainer.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (x86_64-linux)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @globin @fpletz

@WilliButz
Copy link
Member Author

@GrahamcOfBorg test prometheus-exporters.blackbox

@Ma27 Ma27 merged commit f0d6955 into NixOS:master Aug 12, 2019
@Ma27
Copy link
Member

Ma27 commented Aug 12, 2019

@WilliButz thanks!

@WilliButz WilliButz deleted the update-blackbox-exporter branch August 12, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WilliButz @Ma27