New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blackmagic: 1.6.1 -> unstable-2019-08-13 #66469
Conversation
296323f
to
e5fcb21
Compare
e5fcb21
to
ca1cd04
Compare
ca1cd04
to
1ca1b7f
Compare
Other than that, this looks good to me! |
@GrahamcOfBorg build blackmagic |
1ca1b7f
to
07705c1
Compare
@thoughtpolice This is what's in the manual
For consistency for the tree I've been trying to have
I'll have to check this again, but last time I discussed this with someone there wasn't an issue with |
Ah, I see. I wasn't aware we actually had recommendations for this (personally I find dates a little less informative than the actual git-based string, and that's what I've been using for a long time, while being somewhat nicer for a user to tell -- but that's neither here nor there.) I retract my complaint, then! |
TBH we should change these recommendations to something a little bit better, IIRC all packages that use this versioning are ignored by repology. |
07705c1
to
9ad40f1
Compare
Okay, I swapped the version back to the date format. I left out the |
|
Okay, I bumped the commit and added the
|
9ad40f1
to
54eef5c
Compare
54eef5c
to
d792c84
Compare
It's likely you'll find more entries in |
Thanks for contributing @emilazy. Apologies on the little speed bump around |
I updated the version number to include the commit ID as upstream
apparently doesn't plan on making another stable release:
blackmagic-debug/blackmagic#486
This is my first nixpkgs contribution, so apologies if I've messed
anything up! I had to switch to a newer
gcc-arm-embedded
to get itto compile properly.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @pjones