Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-varnish-exporter: 1.5 -> 1.5.1, use buildGoModule #66472

Merged
merged 1 commit into from Aug 12, 2019
Merged

prometheus-varnish-exporter: 1.5 -> 1.5.1, use buildGoModule #66472

merged 1 commit into from Aug 12, 2019

Conversation

WilliButz
Copy link
Member

Motivation for this change

Update to latest minor.

Things done

Switched to buildGoModule and removed the old deps file.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (x86_64-linux & aarch64-linux)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WilliButz
Copy link
Member Author

@GrahamcOfBorg test prometheus-exporters.varnish

@ofborg ofborg bot requested a review from kalbasit August 11, 2019 11:07
@risicle
Copy link
Contributor

risicle commented Aug 11, 2019

Appears to WFM macos 10.13

@kalbasit kalbasit merged commit 4d74651 into NixOS:master Aug 12, 2019
@WilliButz WilliButz deleted the update-varnish-exporter branch August 12, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WilliButz @risicle @kalbasit