Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move certain GNOME3 options to programs #66398

Merged
merged 6 commits into from Aug 10, 2019
Merged

Move certain GNOME3 options to programs #66398

merged 6 commits into from Aug 10, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Fixes #66302

I noticed while moving gpaste that it used sessionPath.
Do we still need that @jtojnar?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jtojnar
Copy link
Contributor

jtojnar commented Aug 10, 2019

I do not think it should be necessary. I even removed it in f63d94e. No sure how it got back.

@worldofpeace
Copy link
Contributor Author

Weird, GitHub says that change never touched that file

Will fix that here.

@worldofpeace
Copy link
Contributor Author

Did that @jtojnar 7e3c8fa

jtojnar
jtojnar approved these changes Aug 10, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, seems to work now.

building the system configuration...
trace: warning: The option `services.gnome3.gpaste.enable' defined in `/home/jtojnar/Projects/nix-playground/gdm-fail.nix' has been renamed to `programs.gpaste.enable'.

@worldofpeace worldofpeace merged commit 1ce7ece into NixOS:master Aug 10, 2019
@worldofpeace worldofpeace deleted the gnome3-option-renames branch August 10, 2019 15:17
@worldofpeace
Copy link
Contributor Author

Thanks @jtojnar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename several GNOME3 options
2 participants
@worldofpeace @jtojnar