The copy pasting of these expressions is kinda problematic, I was going to add it in #65916 but I couldn't bring my self to copy one of them or refactor it to a generic function.

Perhaps there should be an issue for this.

Thanks. Will make the change when I get a chance next - hopefully today :)

Hmm yeah I think upping the default version would be good, but need to check dependencies?

Re refactoring - maybe, but they're minimally different - newer versions depend on at-spi2-core, and I think some earlier versions are missing it (iirc, maybe I'm wrong though).. Having said that - is there a need to support old versions?

Hmm yeah I think upping the default version would be good, but need to check dependencies?

See

• https://electronjs.org/docs/tutorial/support#supported-versions

I think the oldest should be the current default. (needs no change)

Re refactoring - maybe, but they're minimally different - newer versions depend on at-spi2-core, and I think some earlier versions are missing it (iirc, maybe I'm wrong though).. Having said that - is there a need to support old versions?

I believe we should keep

• 6.x
• 5.x
• 4.x

and drop 3.x. @manveru Does this sound correct?

And when we remove the electron_3 attribute we should add a throw to aliases.nix like

electron_3 = throw "deprecated 2019-08-09: use the electron attribute for the currently supported version.";

@worldofpeace the 2 mentioned items are now done :)