New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maestral: init at 0.2.6 #66420
maestral: init at 0.2.6 #66420
Conversation
|
||
postInstall = '' | ||
makeWrapper $out/bin/maestral $out/bin/maestral-gui \ | ||
--add-flags gui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this only be added when withGui
is true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can reproduce @alexarice's failure with nix-shell --pure
. The failure is due to using makeWrapper
here; it should be makeQtWrapper
or makeWrapper ... ${qtWrapperArgs[@]}
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn those impurities.... Thanks @ttuegel. Fixed.
meta = with lib; { | ||
description = "Open-source Dropbox client for macOS and Linux"; | ||
license = licenses.mit; | ||
maintainer = with maintainers; [ peterhoeg ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be maintainers instead of maintainer
Thanks @alexarice, all sorted. |
I get this error when using nix-review:
any ideas? |
Yep, it's due to a missing wrapQtAppsHook - https://nixos.wiki/wiki/Qt It actually works if you install it in your environment but now your can also just execute it directly. |
@@ -0,0 +1,38 @@ | |||
{ lib, python3Packages, fetchFromGitHub, wrapQtAppsHook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should be wrapQtAppsHook ? null
so that maestral
(no gui) can build and ofBorg will stop complaining
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're absolutely right!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think doing this prevents the argument from being substituted automatically by callPackage
. Could you add an assert withGui => !(wrapQtAppsHook == null)
? The error that @alexarice has below would be symptomatic of this failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may be true but also did not solve the problem I'm having
Unfortunately I get the same error |
That's weird. If I do this, everything works: nix-build -A maestral -A maestral-gui $(pwd) && result-2/bin/maestral-gui |
I'll try it without nix-review |
Try this: nix-env -i ./result-2 And then just run |
same error |
xcb seems to be an X library, could the problem be due to me running wayland? |
What happens if you run it this way then: QT_QPA_PLATFORM=wayland-egl maestral-gui |
no change |
Sorry for being unhelpful, I feel the best way forward might be to see if anyone else shares my issue |
Sorry for being unhelpful, I feel the best way forward might be to see if
anyone else shares my issue
Nothing to apologise for. I'm not using wayland so I can't really help with anything further - I don't know why it's trying to load the X plugin instead of the relevant wayland plugin.
|
wrapQtProgram fixed my previous error.
|
KeyError: 'DROPBOX_API_KEY'
[1] 6765 abort result-2/bin/maestral-gui
Yep, you need to set DROPBOX_API_KEY and DROPBOX_API_SECRET. It's mentioned in upstream's readme.
|
Everything is likely working for me then |
Motivation for this change
Open Source dropbox client - works great!
Cc: @ttuegel
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @