Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: 0.28.0 -> 0.28.1 #66402

Merged
merged 1 commit into from
Aug 10, 2019
Merged

bazel: 0.28.0 -> 0.28.1 #66402

merged 1 commit into from
Aug 10, 2019
+2 −2

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Aug 9, 2019 •
edited
Loading

Motivation for this change

bazelbuild/bazel@0.28.0...0.28.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Profpatsch @guibou

Sorry, something went wrong.

@kalbasit kalbasit requested a review from Profpatsch as a code owner August 9, 2019 20:53
@kalbasit
Copy link
Member Author

kalbasit commented Aug 9, 2019

@GrahamcOfBorg build bazel bazel.tests

@kalbasit
Copy link
Member Author

Tested locally on Linux & Darwin. Works great!

@kalbasit kalbasit merged commit b3668d6 into NixOS:master Aug 10, 2019
@kalbasit kalbasit deleted the nixpkgs_update-bazel branch August 10, 2019 00:30
@Profpatsch
Copy link
Member

Yet, the tests fail. I’m tempted to revert.

@Profpatsch
Copy link
Member

Tested locally on Linux & Darwin. Works great!

Ah, you mean you ran the tests on a local Darwin setup? I remember we had problems with the Darwin bazel build on the nixpkgs CI before, is this the same?

@kalbasit
Copy link
Member Author

kalbasit commented Aug 12, 2019 •
edited
Loading

@Profpatsch yes precisely. Darwin ofborg is still unstable. I built bazel and bazel.tests on both Linux & Darwin locally and it worked well. I also checked the changes upstream, was just a logical change in the java code with no changes to the dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kalbasit @Profpatsch