Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify a correct unit description #112

Merged
merged 1 commit into from Jul 5, 2019

Conversation

dminuoso
Copy link

@dminuoso dminuoso commented Jul 4, 2019

The systemd unit has an incorrect specification. The intent of the description is as per systemd documentation (https://www.freedesktop.org/software/systemd/man/systemd.unit.html):

Description=¶

    A human readable name for the unit. This is used by systemd (and other UIs) as the label for the unit, so this string should identify the unit rather than describe it, despite the name. "Apache2 Web
            Server" is a good example. Bad examples are "high-performance light-weight
            HTTP server" (too generic) or "Apache2" (too specific and meaningless for people who do not know Apache). systemd will use this string as a noun in status messages ("Starting
            description...", "Started
            description.", "Reached target
            description.", "Failed to start
            description."), so it should be capitalized, and should not be a full sentence or a phrase with a continous verb. Bad examples include "exiting the container" or "updating the database once per
            day.".```

This is what you see in the log right now

Jul 04 16:59:42 Verleihnix systemd[1]: Starting Sets the offset to 3 °C, so the new trip point is 97 °C...
Jul 04 16:59:42 Verleihnix systemd[1]: Started Sets the offset to 3 °C, so the new trip point is 97 °C.

@Mic92 Mic92 merged commit 54268d1 into NixOS:master Jul 5, 2019
@Mic92
Copy link
Member

Mic92 commented Jul 5, 2019

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants