Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waifu2x-converter-cpp: 5.2.4 -> 5.3 + OpenCL support #64345

Closed
wants to merge 1 commit into from
Closed

waifu2x-converter-cpp: 5.2.4 -> 5.3 + OpenCL support #64345

wants to merge 1 commit into from

Conversation

gloaming
Copy link
Contributor

@gloaming gloaming commented Jul 5, 2019 •
edited

Also with working tests and version info.

Motivation for this change

OpenCL allows the program to run on AMD GPUs.

Things done

nix path-info -S:

/nix/store/jla4yvh2wsrprfbm4wkrkakk0k62s91s-waifu2x-converter-cpp-5.2.4   199550760
/nix/store/flywi3hjjygvldcsx3ljgqkbx2dz4gsn-waifu2x-converter-cpp-5.3     199771712
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gloaming
waifu2x-converter-cpp: 5.2.4 -> 5.3
4dc23bd 
plus OpenCL support and working tests
xzfc
xzfc reviewed Jul 12, 2019
View reviewed changes
pkgs/tools/graphics/waifu2x-converter-cpp/default.nix
, opencl-headers
, opencv3
, pkgconfig
, waifu2x-converter-cpp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to pass doCheck as an option instead of this kind of self reference?
Like here:

nixpkgs/pkgs/development/libraries/glib/default.nix

Line 8 in 157d56d

, doCheck ? config.doCheckByDefault or false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that seems a lot simpler!

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@ajs124
Copy link
Member

ajs124 commented Jun 1, 2020

Needs a rebase. And upstream is at 5.3.3 now. Also @xzfc's feedback should be incorporated.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@veprbl
Copy link
Member

veprbl commented Mar 23, 2021

@gloaming thank you for your contribution. I see that 5.3.4 is in the master, so let's close this. Feel free to resubmit opencl support in the new PR.

@veprbl veprbl closed this Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzfc xzfc xzfc left review comments

Assignees
No one assigned
Labels
2.status: merge conflict 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gloaming @ajs124 @veprbl @xzfc @ryantm