haskellPackages.servant-client-core: apply patch only to 0.15 #64343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @domenkozar as patch author |
domenkozar
reviewed
Jul 5, 2019
| inherit (pkgs.lib) getVersion versionOlder versionAtLeast; | ||
| scc = super.servant-client-core; | ||
| v = getVersion scc; | ||
| in if versionOlder v "0.16" && versionAtLeast v "0.15" then |
There was a problem hiding this comment.
Bug was fixed in 0.16, so it should only be applied to 0.15
There was a problem hiding this comment.
Isn't that exactly what this does? 0.15 => v > 0.16. So basically ~> 0.15.
EDIT: There are no servant releases 0.15 => v > 0.16 other than 0.15. I'm simplifying the patch, give me a minute.
There was a problem hiding this comment.
Ah I assumed versionOlder is not inclusive and you'd then rather write `servant-client-core.version == "0.15"
There was a problem hiding this comment.
Yeah, but it was also unnecessarily complex, given that there were never any patch releases for 0.15. I just didn't bother to check. I've simplified the check significantly with that in mind.
mkaito
force-pushed
the
mkaito/haskell-fix-servant-014
branch
from
6d13eb6
to
52ffb41
Compare
A patch was added unconditionally that only applies to 0.15, breaking builds of 0.14. Apply patch only if version is 0.15
mkaito
force-pushed
the
mkaito/haskell-fix-servant-014
branch
from
52ffb41
to
d7ee2e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
A patch was added unconditionally that only applies to 0.15, breaking
builds of 0.14.
Things done
Apply patch only if version is 0.15.*
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)