Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix steam-run expression #64315

Merged
merged 1 commit into from Jul 1, 2021
Merged

docs: fix steam-run expression #64315

merged 1 commit into from Jul 1, 2021

Conversation

chris-martin
Copy link
Contributor

The newStdCpp argument no longer exists, and the parentheses were in the wrong place.

das-g
das-g suggested changes Jul 5, 2019
View reviewed changes
doc/package-specific-user-notes.xml Outdated Show resolved Hide resolved
@chris-martin
Copy link
Contributor Author

I added another commit to simplify the instructions to just using the steam-run-native package. (I'll squash them if anyone wants, but I think the two separate commits tell a more clear story.)

@worldofpeace
Copy link
Contributor

But shouldn't we explain that there's two steam-run packages and how their differences are for different purposes?

@chris-martin
Copy link
Contributor Author

I don't know, I don't understand what their differences are. I just wanted to correct an obvious inaccuracy. I think this PR does that. I have no doubt that after it is merged, it could be improved further.

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@das-g
Copy link
Member

das-g commented Jun 1, 2020

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me".

still important to me 🤗

@chris-martin Can you resolve the merge conflict?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@davidak
Copy link
Member

davidak commented Jan 30, 2021

I just ran into this issue.

error: anonymous function at /nix/store/5ffnpfgddmlp1migc40b32hrk5pg4gif-nixos-20.09.2660.da3378c4aaf/nixos/pkgs/games/steam/fhsenv.nix:1:1 called with unexpected argument 'newStdcpp', at /nix/store/5ffnpfgddmlp1migc40b32hrk5pg4gif-nixos-20.09.2660.da3378c4aaf/nixos/lib/customisation.nix:69:16
(use '--show-trace' to show detailed location information)

Please rebase and merge.

@Mic92
Copy link
Member

Mic92 commented Jan 30, 2021

This file no longer exists.

@das-g
Copy link
Member

das-g commented Jan 31, 2021 •
edited

This file no longer exists.

This content is now at doc/builders/packages/steam.section.md#steam-run-sec-steam-run:

nixpkgs/doc/builders/packages/steam.section.md

Lines 54 to 69 in cb06a8a

## steam-run {#sec-steam-run}
The FHS-compatible chroot used for steam can also be used to run other linux games that expect a FHS environment. To do it, add
```nix
pkgs.steam.override ({
nativeOnly = true;
newStdcpp = true;
}).run
```
to your configuration, rebuild, and run the game with
```
steam-run ./foo
```

@chris-martin
docs: update Steam instructions to use steam-run-native package
023489f 
pkgs.steam-run-native is defined as exactly the expression that
these instructions tell you to write, so the instruction is no
longer necessary since we can just tell you to use that.
@chris-martin
Copy link
Contributor Author

Rebased.

@davidak davidak merged commit 9e2a8a2 into NixOS:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

@das-g das-g das-g approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@chris-martin @worldofpeace @das-g @davidak @Mic92 @ryantm