Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.{seekpath,sumo,sopel}: fix builds #64303

Merged
merged 5 commits into from Jul 5, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Follow up to #64279, just ignore one failing test rather than disabling a whole package.

Fixed the sumo package as well, the tests were not being collected correctly without pytest.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Jul 4, 2019

@GrahamcOfBorg build pythonPackages.sumo pythonPackages.seekpath

@jonringer jonringer changed the title pythonPackages.{seekpath,sumo}: fix builds pythonPackages.{seekpath,sumo,sopel}: fix builds Jul 4, 2019
@jonringer
Copy link
Contributor Author

since #64277 got merged, decided to rebase and fix sopel as well.

@jonringer
Copy link
Contributor Author

$ nix-review pr 64303 passes on NixOS

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/64303
10 package were build:
python27Packages.geoip2 python27Packages.maxminddb python27Packages.seekpath python27Packages.sopel python27Packages.sumo python37Packages.geoip2 python37Packages.maxminddb python37Packages.seekpath python37Packages.sopel python37Packages.sumo

@jonringer
Copy link
Contributor Author

upstreamed praw version bump here sopel-irc/sopel#1653

@teto
Copy link
Member

teto commented Jul 5, 2019

@GrahamcOfBorg build pythonPackages.maxminddb pythonPackages.geoip2 pythonPackages.sopel pythonPackages.sumo pythonPackages.seekpath

@teto teto merged commit 1d9960a into NixOS:master Jul 5, 2019
@jonringer jonringer deleted the sumo-fix-tests branch July 9, 2019 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants